Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to Julia 1.9, use extensions remove Requires for collect_results and Dataframes #399

Open
Datseris opened this issue Oct 17, 2023 · 3 comments
Open

Move to Julia 1.9, use extensions remove Requires for collect_results and Dataframes #399

Datseris opened this issue Oct 17, 2023 · 3 comments
Labels
good first issue Easy issue good for newcomers update Updates in the source code or documentation are necessary.

Comments

@Datseris
Copy link
Member

The title says it all, currently we use Requires for collect_results. We should not do that as Julia natively supports conditional dependencies via the extensions. See here for how to do it: https://pkgdocs.julialang.org/dev/creating-packages/#Conditional-loading-of-code-in-packages-(Extensions)
@Datseris Datseris added good first issue Easy issue good for newcomers update Updates in the source code or documentation are necessary. labels Oct 17, 2023
@denfc
Copy link

denfc commented Jul 20, 2024

We should not do that

Via PkgDependency, I see that DrWatson v2.15.0. still uses Requires. Is an update on the way or should I learn to implement conditional dependencies? If the latter, could you post the code you use?

Thanks!

-- dfc

@Datseris
Copy link
Member Author

https://pkgdocs.julialang.org/v1/creating-packages/#Conditional-loading-of-code-in-packages-(Extensions)

@Datseris
Copy link
Member Author

this has the code/instructions for how to do it.

franzi448 pushed a commit to franzi448/DrWatson.jl that referenced this issue Aug 20, 2024
Issue JuliaDynamics#399 package dependencies
2f077f8
franzi448 added a commit to franzi448/DrWatson.jl that referenced this issue Aug 27, 2024
@franzi448
Merge branch 'JuliaDynamics:main' into Issue-JuliaDynamics#399
187df81
franzi448 pushed a commit to franzi448/DrWatson.jl that referenced this issue Sep 2, 2024
Merge branch 'Issue-JuliaDynamics#399' of github.com:franzi448/DrWats…
7db8aed 
…on.jl into Issue-JuliaDynamics#399
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Easy issue good for newcomers update Updates in the source code or documentation are necessary.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Datseris @denfc