Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Remainder, still need the tests #27

Closed
wants to merge 18 commits into from

Conversation

mrr00b00t
Copy link
Contributor

Trying to add Remainder transformation, but the tests is needed

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2021

Codecov Report

Merging #27 (d56485d) into master (806be6f) will decrease coverage by 4.09%.
The diff coverage is 0.00%.

❗ Current head d56485d differs from pull request most recent head aa744f6. Consider uploading reports for the commit aa744f6 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
- Coverage   77.50%   73.41%   -4.10%     
==========================================
  Files          12       12              
  Lines         289      331      +42     
==========================================
+ Hits          224      243      +19     
- Misses         65       88      +23     
Impacted Files Coverage Δ
src/transforms/remainder.jl 0.00% <0.00%> (ø)
src/transforms/closure.jl 86.36% <0.00%> (+86.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 806be6f...aa744f6. Read the comment docs.

@mrr00b00t
Copy link
Contributor Author

mrr00b00t commented Nov 2, 2021

I was writing the tests but forgot that the other PR will make changes in tests/transforms.jl, so I decided not to push the tests for the Remainder for now.

src/transforms/remainder.jl Outdated Show resolved Hide resolved
src/transforms/remainder.jl Outdated Show resolved Hide resolved
src/transforms/remainder.jl Outdated Show resolved Hide resolved
src/CoDa.jl Outdated Show resolved Hide resolved
src/transforms/remainder.jl Outdated Show resolved Hide resolved
src/transforms/remainder.jl Outdated Show resolved Hide resolved
src/transforms/remainder.jl Outdated Show resolved Hide resolved
src/CoDa.jl Outdated Show resolved Hide resolved
src/transforms/remainder.jl Outdated Show resolved Hide resolved
src/transforms/remainder.jl Outdated Show resolved Hide resolved
src/transforms/remainder.jl Outdated Show resolved Hide resolved
src/transforms/remainder.jl Outdated Show resolved Hide resolved
src/transforms/remainder.jl Outdated Show resolved Hide resolved
Copy link
Member

@juliohm juliohm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've finished adjusting small details. Now we need two more adjustments:

  1. The column :remainder should be called total_minus_abcdef... where abcdef is just a concatenation of names in the variable names.
  2. The two function apply and reapply only differ by the definition of total = func(transform, table, cache). In apply the function computes the total and in reapply the function reads the cache. Can you try to refactor the code that way so that we reduce the amount of code repetition?

src/transforms/remainder.jl Outdated Show resolved Hide resolved
src/transforms/remainder.jl Outdated Show resolved Hide resolved
src/transforms/remainder.jl Outdated Show resolved Hide resolved
src/transforms/remainder.jl Outdated Show resolved Hide resolved
src/transforms/remainder.jl Outdated Show resolved Hide resolved
@juliohm
Copy link
Member

juliohm commented Nov 2, 2021

Closing in favor of #28

@juliohm juliohm closed this Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants