Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the Composition type constructors #42

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Refactor the Composition type constructors #42

merged 2 commits into from
Nov 28, 2023

Conversation

eliascarv
Copy link
Member

@eliascarv eliascarv commented Nov 28, 2023

master:

julia> Random.seed!(2);

julia> inds = shuffle(1:100_000);

julia> coda = CoDaArray((a = rand(100_000), b = rand(100_000), c = rand(100_000)));

julia> @btime coda[inds];
  5.380 s (4299492 allocations: 161.74 MiB)

This PR:

julia> Random.seed!(2);

julia> inds = shuffle(1:100_000);

julia> coda = CoDaArray((a = rand(100_000), b = rand(100_000), c = rand(100_000)));

julia> @btime coda[inds];
  18.994 ms (500002 allocations: 18.31 MiB)

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d49daf5) 84.71% compared to head (9d2d580) 84.91%.

Files Patch % Lines
src/compositions.jl 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
+ Coverage   84.71%   84.91%   +0.19%     
==========================================
  Files           9        9              
  Lines         229      232       +3     
==========================================
+ Hits          194      197       +3     
  Misses         35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juliohm juliohm merged commit 65d4281 into master Nov 28, 2023
6 checks passed
@juliohm juliohm deleted the composition branch November 28, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants