-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
for outer loops #130
for outer loops #130
Conversation
8eda57d
to
029bb55
Compare
I didn't even know that Anyone else willing to review this? |
Well, it's 0.7 only, and I vaguely remember that there was a PR that added it. Can't really be bothered to look for it though, so tagging @ararslan again :) |
Correct, though it can annotate any variable in the loop declaration, e.g. i = j = 1
for outer i = 1:10, outer j = 3:4
# ...
end It is indeed 0.7 only, added in JuliaLang/julia#22659. |
That case is surprisingly difficult to handle properly... |
You may be able to take a look at how the Vim plugin does it; I think Carlo figured it out somehow. |
even on multiple lines :)
Okay, this should be mostly fine now. |
and better specs
Alright, should really work now and handle most cases properly :) |
Barring any objections I'll merge this tomorrow(-ish). |
Fixes #129.
outer
is only a keyword infor outer
loops, right?