Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Fix backslash-indentation and dotted-operator indentation #85

Closed
wants to merge 2 commits into from

Conversation

non-Jedi
Copy link
Contributor

Closes #58. Closes #56.

There may be a better way of handling dotted operators, but I went with matching what was already there.

@non-Jedi
Copy link
Contributor Author

I missed the bit where \ has to be an escape char for string escaping to work correctly. For reference of how to do this correctly see octave-syntax-propertize-sqs. Don't have time to fix this evening.

@non-Jedi non-Jedi changed the title Fix backslash-indentation and dotted-operator indentation WIP: Fix backslash-indentation and dotted-operator indentation Nov 12, 2019
@non-Jedi
Copy link
Contributor Author

The fix here is dependent on dropping Emacs 23 support (#86). Not going to implement twice, once with syntax-propertize-function and once without.

@tpapp
Copy link
Collaborator

tpapp commented Nov 14, 2019

This is fine, I will just wait a month for feedback before merging #86.

@non-Jedi
Copy link
Contributor Author

non-Jedi commented Mar 9, 2020

This is going to end up looking entirely different when I get around to it. Will open a new PR.

@non-Jedi non-Jedi closed this Mar 9, 2020
@tpapp
Copy link
Collaborator

tpapp commented Mar 9, 2020

Great, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong indentation with .|> \( upsets paren matching
2 participants