(WIP) Use LanguageServer.jl for better completions #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: better annotator
ice1000
reviewed
Aug 15, 2019
| } | ||
| dependencies { | ||
| compile("org.jetbrains", "markdown", "0.1.31") | ||
| } |
There was a problem hiding this comment.
Can you eliminate these whitespaces changes?
| <moduleConfigurationEditorProvider implementation="org.ice1000.julia.lang.module.JuliaModuleConfigEditor"/> | ||
| --> |
| @@ -54,12 +56,28 @@ | |||
| <stubIndex implementation="org.ice1000.julia.lang.psi.JuliaAbstractTypeDeclarationIndex"/> | |||
| <stubIndex implementation="org.ice1000.julia.lang.psi.JuliaTypeDeclarationIndex"/> | |||
| <stubIndex implementation="org.ice1000.julia.lang.psi.JuliaModuleDeclarationIndex"/> | |||
| <localInspection displayName="LSP" | |||
There was a problem hiding this comment.
Can the display name be changed to "language server" or "julia language server"?
| <completion.contributor | ||
| language="Julia" | ||
| implementationClass="org.ice1000.julia.lang.editing.JuliaBasicCompletionContributor"/> | ||
| --> |
| @@ -95,4 +98,4 @@ class JuliaCompileOutputEditor(state: ModuleConfigurationState) : ModuleElements | |||
| override fun getDisplayName() = "Paths" | |||
| override fun getHelpTopic() = editor.helpTopic | |||
| } | |||
|
|
|||
| */ | |||
|
I am quite busy with my job/study recently. This is just a PoC. If you'd like to take over this, feel free to just use the working parts and close this PR. |
|
Ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #338
This is a very buggy PoC obviously