Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip execution of Julia startup file when checking for envdir #561

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sorokod
Copy link

@sorokod sorokod commented Mar 28, 2021

The change to getEnvDir() is implemented using a non interactive call to Julia ( -E ) and required a change for executeCommand to accept multiple arguments.

@sorokod sorokod changed the title Skip execution of startup file when checking for Julia envdir Skip execution of Julia startup file when checking for Julia envdir Mar 28, 2021
@sorokod sorokod changed the title Skip execution of Julia startup file when checking for Julia envdir Skip execution of Julia startup file when checking for envdir Mar 28, 2021
@sorokod
Copy link
Author

sorokod commented Mar 28, 2021

I bumped my local Kotlin version to 1.4 to avoid the error here ...available since Kotlin 1.4 and cannot be used in Kotlin 1.3 but the error has nothing to do with a change in this PR.

@ice1000 , does master builds for you with 1.3 ?

@ice1000
Copy link
Member

ice1000 commented Mar 28, 2021

I bumped my local Kotlin version to 1.4 to avoid the error here ...available since Kotlin 1.4 and cannot be used in Kotlin 1.3 but the error has nothing to do with a change in this PR.

@ice1000 , does master builds for you with 1.3 ?

Idk, I haven't built this for a while

@ice1000
Copy link
Member

ice1000 commented Mar 28, 2021

This PR LGTM so far

@ice1000 ice1000 self-assigned this Mar 28, 2021
@ice1000 ice1000 requested a review from zxj5470 March 28, 2021 17:31
@sorokod
Copy link
Author

sorokod commented Mar 28, 2021

For whatever it's worth, my changes to the build

  kotlin("jvm") version "1.4.31"
  ...
  setPlugins("PsiViewer:211-SNAPSHOT", "java")
 ...
	kotlinOptions {
		jvmTarget = "1.8"
		languageVersion = "1.4"
		apiVersion = "1.4"
		...
	}


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants