Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests #24

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Add tests #24

wants to merge 5 commits into from

Conversation

nick4f42
Copy link

@nick4f42 nick4f42 commented Jul 5, 2024

#23

Copied indent, font-lock, and movement tests from julia-mode-tests.el. As of now, 25/60 tests fail when using julia-ts-mode instead of julia-mode.

It would be better if we could somehow use julia-mode-tests.el without copying it into this repository. Maybe the best way would be to move julia-ts-mode to https://github.com/JuliaEditorSupport/julia-emacs?

@nick4f42 nick4f42 marked this pull request as draft July 5, 2024 11:45
This way, configuration that affects the indent rules doesn't have to
be set before loading the library.
@nick4f42
Copy link
Author

nick4f42 commented Aug 4, 2024

Fixed a few tests and categorized the rest. Here are the 16/60 that still fail, categorized based on whether a tree-sitter-julia grammar issue is to blame. Tested using the v0.20.0 grammar.

  • Grammar issue
    • julia-ts--test-indent-ignore-:end-as-block-ending
    • julia-ts--test-beginning-of-defun-assn-3
    • julia-ts--test-beginning-of-defun-assn-5
    • julia-ts--test-end-of-defun-assn-1
    • julia-ts--test-char-const-font-lock (this one: ''')
    • julia-ts--test-function-assignment-font-locking
  • Non-grammar issue
    • julia-ts--test-indent-block-inside-hanging-paren
    • julia-ts--test-indent-block-next-to-paren
    • julia-ts--test-indent-operator
    • julia-ts--test-indent-paren-space
    • julia-ts--test-ccall-font-lock
    • julia-ts--test-ternary-font-lock
    • julia-ts--test-typeparams-font-lock
    • julia-ts--test-triple-quote-cmd-font-lock
    • julia-ts--test-triple-quote-string-font-lock
    • julia-ts--test-indentation-of-multi-line-strings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant