Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand initial parameters function and NeuralNetwork constructors #13

Merged

Conversation

benedict-96
Copy link
Collaborator

Implemented initialparameters and NeuralNetwork for all possible input permutations.

@benedict-96 benedict-96 requested a review from michakraus March 8, 2024 12:00
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 81.18%. Comparing base (263f29e) to head (1db6df3).

Files Patch % Lines
src/neural_network.jl 66.66% 4 Missing ⚠️
src/chain.jl 83.33% 1 Missing ⚠️
src/model.jl 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
- Coverage   81.58%   81.18%   -0.41%     
==========================================
  Files          18       18              
  Lines         277      287      +10     
==========================================
+ Hits          226      233       +7     
- Misses         51       54       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benedict-96 benedict-96 marked this pull request as draft March 13, 2024 08:36
@benedict-96 benedict-96 marked this pull request as ready for review March 14, 2024 10:16
…ii) type.

Adjusted all interfaces to fit the template (i) model (ii) backend (iii) type.
@benedict-96 benedict-96 force-pushed the expand_initial_parameters_and_neural_network_constructors branch from 600f1f8 to 1db6df3 Compare March 14, 2024 13:26
@michakraus michakraus merged commit 1559f3b into main Mar 14, 2024
15 checks passed
@michakraus michakraus deleted the expand_initial_parameters_and_neural_network_constructors branch March 14, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants