Update discovery.jl with minimal approach to fix Windows discovery process #839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes only rel_libdir for windows to "dir", otherwise leaves it as "" and leaves lib_prefix untouched to preserve linux functionality.
Member
|
This modification seems to address the discovery issue on Windows and Ubuntu (24.04 - ROCm 6.4 - the CI machine). It would be nice if folks with different OS (Fedora amongst others as per #788) could check whether this fix still enables discovery on their side. |
Member
|
Can confirm everything is still working as expected in Fedora |
Member
|
Thanks @jbiffl ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
rel_libdirfor Windows to "bin", otherwise leaves it as "" and leaveslib_prefixuntouched to preserve Linux functionality.Note:
amdhip64_6.dllis in a subdirectory on Windows, butlibamdhip64.sois top level to the ROCm path in Linux. This difference may cause issues forlibhipin the future if it is ever modified to be consistent across platforms.