Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reason for missing LinearAlgebra wrappers? #46

Closed
danielwe opened this issue Jul 23, 2021 · 1 comment
Closed

Reason for missing LinearAlgebra wrappers? #46

danielwe opened this issue Jul 23, 2021 · 1 comment

Comments

@danielwe
Copy link
Contributor

Is there a reason the WrappedArray union omits some of the basic array wrappers from LinearAlgebra, specifically Symmetric, Hermitian, UpperHessenberg, SymTridiagonal, and Bidiagonal? I know at least symmetric and hermitian matrices have good CUSOLVER support (even if CUDA.jl doesn't wrap everything yet), so at least from the GPU perspective, I don't see an obvious reason why these wouldn't be treated the same as other wrappers.
@danielwe danielwe changed the title Reason for missing wrappers? Reason for missing LinearAlgebra wrappers? Jul 23, 2021
@maleadt
Copy link
Member

maleadt commented Jul 24, 2021

No reason, PRs welcome 🙂

@maleadt maleadt closed this as completed Nov 18, 2021
danielwe added a commit to danielwe/Adapt.jl that referenced this issue Mar 18, 2022
@danielwe
Add support for missing LinearAlgebra wrappers
6957e12 
Hermitian, UpperHessenberg, Bidiagonal, SymTridiagonal

Closes JuliaGPU#46
@danielwe danielwe mentioned this issue Mar 18, 2022
Merged
maleadt pushed a commit to danielwe/Adapt.jl that referenced this issue Oct 23, 2023
@danielwe @maleadt
Add support for missing LinearAlgebra wrappers
8c6bf9b 
Hermitian, UpperHessenberg, Bidiagonal, SymTridiagonal

Closes JuliaGPU#46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maleadt @danielwe