Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix StaticArrays extension. #62

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Fix StaticArrays extension. #62

merged 1 commit into from
Feb 27, 2023

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Feb 27, 2023

Fixes #59, which introduced a broken extension package (didn't load, didn't actually adapt) with nonfunctional tests.

Closes #61

cc @ChrisRackauckas

@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Base: 82.85% // Head: 84.50% // Increases project coverage by +1.64% 🎉

Coverage data is based on head (a7c5739) compared to base (47f5040).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head a7c5739 differs from pull request most recent head 301d046. Consider uploading reports for the commit 301d046 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
+ Coverage   82.85%   84.50%   +1.64%     
==========================================
  Files           6        6              
  Lines          70       71       +1     
==========================================
+ Hits           58       60       +2     
+ Misses         12       11       -1     
Impacted Files Coverage Δ
ext/AdaptStaticArraysExt.jl 100.00% <100.00%> (+100.00%) ⬆️
src/Adapt.jl 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maleadt maleadt merged commit cd9d4b7 into master Feb 27, 2023
@maleadt maleadt deleted the tb/staticarrays branch February 27, 2023 14:51
@ChrisRackauckas
Copy link
Member

Thanks for catching that. How come the test didn't run correctly?

@ChrisRackauckas
Copy link
Member

oh forgot the @test 😅😅😅😅😅😅😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LoadError: ArgumentError: Package AdaptStaticArraysCoreExt does not have Adapt in its dependencies
3 participants