Replace DevicePtr with Core.LLVMPtr. #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maleadt
added
cuda kernels
|
cc @thomasfaingnaert: after removing the addrspacecasts, this also does away with the inttoptr's! Still does a bitcast, since the pointers we emit for LLVMPtr are typeless, but that shouldn't be a problem. cc @jpsamaroo: this simplification probably also applies to the AMD back-end. |
maleadt
force-pushed
the
tb/llvmptr
branch
4 times, most recently
from
5049f48 to
9603993
Compare
maleadt
force-pushed
the
master
branch
11 times, most recently
from
d3147a2 to
cf97309
Compare
maleadt
force-pushed
the
tb/llvmptr
branch
2 times, most recently
from
dcd2d24 to
4196974
Compare
Codecov Report
@@ Coverage Diff @@
## master #199 +/- ##
==========================================
- Coverage 79.34% 79.01% -0.33%
==========================================
Files 165 165
Lines 8742 8730 -12
==========================================
- Hits 6936 6898 -38
- Misses 1806 1832 +26
Continue to review full report at Codecov.
|
marius311
added a commit
to marius311/CUDA.jl
that referenced
this pull request
Sep 8, 2020
[Diff since v1.3.2](JuliaGPU/CUDA.jl@v1.3.2...v1.3.3) **Closed issues:** - Type changing Array conversions give error when allowscalar(false) (JuliaGPU#344) - getindex(::CuArray, ::Adjoint, ::Colon) fails (JuliaGPU#345) - View with array indices causes memory copy before broadcast (JuliaGPU#384) - Regression with Julia 1.5 (JuliaGPU#390) **Merged pull requests:** - Replace DevicePtr with Core.LLVMPtr. (JuliaGPU#199) (@maleadt) - Make sure view indices reside on the GPU too. (JuliaGPU#388) (@maleadt) - CompatHelper: Update DataStructures to v0.18 (JuliaGPU#389) (@ChrisRackauckas)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on JuliaLLVM/LLVM.jl#185
1.5 only, but I want to be sure this works before 1.5 is actually released.