Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark more methods as device methods #2336

Draft
wants to merge 9 commits into
base: vc/precompile_tools
Choose a base branch
from

Conversation

vchuravy
Copy link
Member

Motivated by JuliaLang/julia#54155

@maleadt
Copy link
Member

maleadt commented Apr 19, 2024

Hmm, I purposefully didn't want to overuse overloads as they break e.g. Revise...

@vchuravy vchuravy changed the base branch from master to vc/precompile_tools April 19, 2024 19:14
@vchuravy
Copy link
Member Author

Yeah :/

Did you ever check why Revise breaks? Jameson mentioned a few weeks ago that OverlayMethod tables don't participate in invalidations correctly. (cc: @aviatesk)

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 60.34%. Comparing base (c7f880c) to head (36c125d).

Current head 36c125d differs from pull request most recent head 39549e6

Please upload reports for the commit 39549e6 to get more accurate results.

Files Patch % Lines
src/precompile.jl 12.50% 7 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##           vc/precompile_tools    #2336      +/-   ##
=======================================================
+ Coverage                59.96%   60.34%   +0.37%     
=======================================================
  Files                      156      156              
  Lines                    14989    14893      -96     
=======================================================
- Hits                      8988     8987       -1     
+ Misses                    6001     5906      -95     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maleadt
Copy link
Member

maleadt commented Apr 20, 2024

Jameson mentioned a few weeks ago that OverlayMethod tables don't participate in invalidations correctly.

Yeah, that seems plausible: timholy/Revise.jl#646 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants