Native RNG fixes for very large arrays #2561
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The overflow fix isn't great (sacrificing a couple of additional registers), and we probably have a bunch of similar bugs in other native kernels. I contemplated passing a typevar that determines the type of the counter, but that's additional complexity that's probably not worth it (e.g. in
randn!
the window size depends on the element type, so that would further couple kernel implementation details to the call site).As noted by @thomasfaingnaert