Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CUSPARSE] Fix constructor of sparse empty matrices #2575

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

amontoison
Copy link
Member

@amontoison amontoison commented Dec 2, 2024

  • A.rowPtr should always be [1] for empy matrices in CSR format.
  • A.colPtr should always be [1] for empy matrices in CSC format.
    We want to ensure A.rowPtr[end] == nnz(A) + 1 and A.colPtr[end] == nnz(A) + 1.

The display issue in #2570 is related.

@maleadt maleadt added bugfix This gets something working again. cuda libraries Stuff about CUDA library wrappers. labels Dec 3, 2024
@maleadt
Copy link
Member

maleadt commented Dec 3, 2024

CI failure looks related:

libraries/cusparse/conversions: Error During Test at /var/lib/buildkite-agent/builds/gpuci-11/julialang/cuda-dot-jl/test/libraries/cusparse/conversions.jl:42
  Got exception outside of a @test
  CuArray only supports element types that are allocated inline.
  Any is not allocated inline

@maleadt maleadt force-pushed the master branch 15 times, most recently from 5d585c4 to c850163 Compare December 20, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This gets something working again. cuda libraries Stuff about CUDA library wrappers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants