Skip to content

Conversation

@vchuravy
Copy link
Member

Particularly:

  • pagelock! == pin
  • multi-GPU

@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2025

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic master) to apply these changes.

Click here to view the suggested changes.
diff --git a/src/CUDAKernels.jl b/src/CUDAKernels.jl
index 8091da838..a443f427c 100644
--- a/src/CUDAKernels.jl
+++ b/src/CUDAKernels.jl
@@ -56,11 +56,11 @@ function KA.ndevices(::CUDABackend)
 end
 
 function KA.device(::CUDABackend)
-    deviceid(active_state().device)+1
+    return deviceid(active_state().device) + 1
 end
 
 function KA.device!(::CUDABackend, id)
-    device!(id-1)
+    return device!(id - 1)
 end
 
 ## kernel launch

@maleadt
Copy link
Member

maleadt commented Jan 23, 2025

So you're going with integer device IDs? Not sure that's the most portable decision...

Anyhow, CI failures related.

@maleadt maleadt marked this pull request as draft February 4, 2025 10:41
@maleadt maleadt added enhancement New feature or request dependencies About things we use. labels Feb 4, 2025
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@vchuravy vchuravy marked this pull request as ready for review February 17, 2025 10:20
@maleadt maleadt closed this May 7, 2025
@vchuravy vchuravy deleted the vc/ka_0.9.32 branch May 7, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies About things we use. enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants