Skip to content
This repository has been archived by the owner on May 27, 2021. It is now read-only.

Deprecate atan2 #443

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Deprecate atan2 #443

wants to merge 1 commit into from

Conversation

benchislett
Copy link
Contributor

To be consistent with Julia's atan(x, y) function, I renamed atan2 to atan.
Here's the help message for atan:

atan(y)
atan(y, x)

Compute the inverse tangent of y or y/x, respectively.

For one argument, this is the angle in radians between the positive x-axis and the point (1, y), returning a value in the interval [-\pi/2, \pi/2].

For two arguments, this is the angle in radians between the positive x-axis and the point (x, y), returning a value in the interval [-\pi, \pi]. This corresponds to a standard
atan2 (https://en.wikipedia.org/wiki/Atan2) function.

@maleadt
Copy link
Member

maleadt commented Sep 25, 2019

Hmm, I wonder if we should try and have some deprecation mechanism for changes like this.

@Sleort
Copy link
Contributor

Sleort commented Jan 16, 2020

What's the status here? It would be nice to have this PR merged...

(Regarding deprecation, can't we just use @deprecate atan2(y, x) atan(y, x)?)

@maleadt
Copy link
Member

maleadt commented Jan 16, 2020

No, @depwarn doesn't work on the GPU. We should probably have both definitions until there's a breaking release.

Sleort added a commit to Sleort/CUDAnative.jl that referenced this pull request Jan 16, 2020
@Sleort Sleort mentioned this pull request Jan 16, 2020
bors bot added a commit that referenced this pull request Jan 16, 2020
527: Add atan(y,x) r=maleadt a=Sleort

See also #443

Co-authored-by: Troels Arnfred Bojesen <tr-ab@online.no>
@maleadt maleadt changed the title Rename atan2 to atan Deprecate atan2 Jan 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants