New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove type piracy on Adapt? #296

Closed

piever opened this issue Jun 24, 2020 · 1 comment · Fixed by #348

piever commented Jun 24, 2020

I've noticed that this package is pirating methods from Adapt here. Is there a reason why that method can't go in Adapt?

piever mentioned this issue

CompatHelper: bump compat for "Adapt" to "2.0" JuliaArrays/StructArrays.jl#132

Closed

Member

maleadt commented Jun 24, 2020

That functionality isn't meant to be general-purpose, it's just to implement convert_to_cpu, so we should probably use a locally-defined adaptor.

maleadt mentioned this issue

Don't add a public adapt method for Array. #348

Merged

maleadt closed this as completed in #348

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment