Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for "Adapt" to "2.0" #132

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the Adapt package from 1 to 1, 2.0.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

@andreasnoack
Copy link
Member

@piever Do you know why the tests are failing on older version of Julia?

@piever
Copy link
Collaborator

piever commented Jun 24, 2020

It was a bit of a riddle. As far as I understand, the way to get interoperability with GPU things is to overload Adapt, but to actually use it you need to also import GPUArrays, which (using type piracy) makes sure that Adapt.adapt(Array, x) does the right thing. I think newer Adapt needs a newer GPUArrays, which requires julia 1.3, so tests fail on older julia (it ends up installing a very old GPUArrays version, probably from before there were compat bounds at all).

I can probably test on a custom type (rather than Array) so that I can drop the GPUArrays test dependency (#133).

I've opened an issue on GPUArrays for the type piracy: JuliaGPU/GPUArrays.jl#296

@piever piever closed this Jun 24, 2020
@piever piever deleted the compathelper/new_version/2020-06-22-00-13-27-812-2462069252 branch September 16, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants