Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fill when length = 0 #300

Merged
merged 1 commit into from
Jul 15, 2020
Merged

fix fill when length = 0 #300

merged 1 commit into from
Jul 15, 2020

Conversation

Ellipse0934
Copy link
Contributor

@Ellipse0934 Ellipse0934 commented Jul 15, 2020

As reported in #81 , CUDA.jl . Currently constructors such as CUDA.zeros(T, 0) would fail for the types not handled by CUDA memset (64-bit numbers not supported).

Previously

julia> T = Float64
julia> CuArrays.zeros(T, 0)
ERROR: AssertionError: total_threads > 0
Stacktrace:
 [1] #gpu_call#1 at /scratch/snx3000tds/omlins/9_soft_install_julia_1_4/software/Julia/1.4.1-CrayGNU-19.10-cuda-10.1/extensions/packages/GPUArrays/OXvxB/src/device/execution.jl:60 [inlined]
 [2] gpu_call at /scratch/snx3000tds/omlins/9_soft_install_julia_1_4/software/Julia/1.4.1-CrayGNU-19.10-cuda-10.1/extensions/packages/GPUArrays/OXvxB/src/device/execution.jl:46 [inlined]
 [3] fill!(::CuArray{Float64,1,Nothing}, ::Int64) at /scratch/snx3000tds/omlins/9_soft_install_julia_1_4/software/Julia/1.4.1-CrayGNU-19.10-cuda-10.1/extensions/packages/GPUArrays/OXvxB/src/host/construction.jl:12
 [4] zeros(::Type{T} where T, ::Int64, ::Vararg{Int64,N} where N) at /scratch/snx3000tds/omlins/9_soft_install_julia_1_4/software/Julia/1.4.1-CrayGNU-19.10-cuda-10.1/extensions/packages/CuArrays/l0gXB/src/array.jl:337
 [5] top-level scope at REPL[129]:1

Now:

julia> CUDA.zeros(Float64, 0)
0-element CuArray{Float64,1}

@maleadt
Copy link
Member

maleadt commented Jul 15, 2020

Thanks!
bors r+

@bors
Copy link
Contributor

bors bot commented Jul 15, 2020

@bors bors bot merged commit e1bcb8d into JuliaGPU:master Jul 15, 2020
@Ellipse0934 Ellipse0934 deleted the constructors branch July 15, 2020 17:10
danielwe added a commit to danielwe/GPUArrays.jl that referenced this pull request Nov 29, 2020
Same problem as in JuliaGPU#81, fixed in JuliaGPU#300, but for `repeat`.
danielwe added a commit to danielwe/GPUArrays.jl that referenced this pull request Nov 29, 2020
Same problem as in JuliaGPU#81, fixed in JuliaGPU#300, but for `repeat`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants