Simplify conversions. #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,5 +1,14 @@ | |||
| # convenience and indirect construction | |||
|
|
|||
| # conversions from CPU arrays rely on constructors | |||
| Base.convert(::Type{T}, a::AbstractArray) where {T<:AbstractGPUArray} = a isa T ? a : T(a) | |||
There was a problem hiding this comment.
This looks like a potential for a lot of invalidations. Was that checked?
There was a problem hiding this comment.
No, I didn't check for that. We did used to have a Base.convert(AT::Type{<: AbstractGPUArray}, iter) method though, which is worse (right?), and I don't remember this convert method standing out when I had a quick look at invalidations a couple of weeks ago.
There was a problem hiding this comment.
Yeah, this should at least be better. Interesting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just rely on a constructor to do the AbstractArray -> <:AbstractGPUArray conversion (coverage indicated these weren't used anyway). I hope to one day reinstate those actual constructors, i.e. what was removed in #169, but those are very tricky (wrt. ambiguities, and there being no interface to go from a
::Type{<:AbstractGPUArray{T,N}}to a concrete<:AbstractGPUArray{S,N}).