Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to LLVM.jl 8 #591

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Adapt to LLVM.jl 8 #591

merged 1 commit into from
Jun 27, 2024

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Jun 27, 2024

No description provided.

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 17 lines in your changes missing coverage. Please review.

Project coverage is 73.68%. Comparing base (8b513be) to head (1435e7f).

Files Patch % Lines
src/driver.jl 50.00% 7 Missing ⚠️
src/irgen.jl 60.00% 4 Missing ⚠️
src/metal.jl 77.77% 4 Missing ⚠️
src/optim.jl 96.07% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #591      +/-   ##
==========================================
- Coverage   82.29%   73.68%   -8.61%     
==========================================
  Files          24       24              
  Lines        3406     3413       +7     
==========================================
- Hits         2803     2515     -288     
- Misses        603      898     +295     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maleadt maleadt force-pushed the tb/newpm branch 3 times, most recently from 91c9e8c to d529db7 Compare June 27, 2024 09:46
@maleadt
Copy link
Member Author

maleadt commented Jun 27, 2024

Hmm, I guess NVVMReflect is not available directly, so we'll have to solve deal with #547, e.g., by making sure we augment the pass builder with target specific passes.

EDIT: Actually, no, it was just a typo.

@maleadt
Copy link
Member Author

maleadt commented Jun 27, 2024

CI failure happens on master too. Let's fix it separately.

@maleadt maleadt merged commit b020206 into master Jun 27, 2024
13 of 21 checks passed
@maleadt maleadt deleted the tb/newpm branch June 27, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant