Skip to content

Conversation

gbaraldi
Copy link
Member

This depends on JuliaLang/julia#57824 being merged to add a correct version check

Copy link
Contributor

github-actions bot commented Mar 18, 2025

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic master) to apply these changes.

Click here to view the suggested changes.
diff --git a/src/jlgen.jl b/src/jlgen.jl
index 6dd691e..e0e9383 100644
--- a/src/jlgen.jl
+++ b/src/jlgen.jl
@@ -625,7 +625,7 @@ function compile_method_instance(@nospecialize(job::CompilerJob))
         cgparams = (; lookup = Base.unsafe_convert(Ptr{Nothing}, lookup_cb), cgparams... )
     end
     if VERSION > v"1.13.0-DEV.285"
-        cgparams = (; force_emit_all = true , cgparams...)
+        cgparams = (; force_emit_all = true, cgparams...)
     end
     params = Base.CodegenParams(; cgparams...)
 

@maleadt
Copy link
Member

maleadt commented Mar 25, 2025

Still some nightly issues, but much better. Thanks @gbaraldi!

@maleadt maleadt merged commit 5a14f02 into JuliaGPU:master Mar 25, 2025
14 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants