KernelIntrinsics API #635
Open
KernelIntrinsics API #635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your PR requires formatting changes to meet the project's style guidelines. Click here to view the suggested changes.diff --git a/test/intrinsics.jl b/test/intrinsics.jl
index e58b58a6..a586de08 100644
--- a/test/intrinsics.jl
+++ b/test/intrinsics.jl
@@ -20,7 +20,7 @@ end
function intrinsics_testsuite(backend, AT)
- @testset "KernelIntrinsics Tests" begin
+ return @testset "KernelIntrinsics Tests" begin
@testset "Basic intrinsics functionality" begin
# Test with small kernel |
christiangnrd
force-pushed
the
intrinsics
branch
3 times, most recently
from
c16a665 to
b166baa
Compare
|
Can you rebase? |
christiangnrd
force-pushed
the
intrinsics
branch
from
b166baa to
928e6fd
Compare
This comment was marked as outdated.
This comment was marked as outdated.
christiangnrd
force-pushed
the
intrinsics
branch
from
928e6fd to
cd7476e
Compare
Closed
vchuravy
reviewed
Oct 6, 2025
Comment on lines
+54
to
+58
| function localmemory end | ||
| function barrier() | ||
| error("Group barrier used outside kernel or not captured") | ||
| end | ||
| function print end |
|
@christiangnrd do you think we need a lower-level kernel launch interface? Otherwise the three-dimensional indices would be superflous. |
christiangnrd
force-pushed
the
intrinsics
branch
from
cd7476e to
84d0c68
Compare
I'd been thinking about that and I think so. Would something that, assuming you wrote the whole kernel with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to allow for kernels to be written without relying on KernelAbstractions macros
@vchuravy @maleadt