Fix macos with workaround #209
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts the changes for MacOS from commit "Add OpenCL_jll dependence" JuliaGPU#196 However, consider this as a dirty workaround to get macos back running. Fixing this within the OpenCL_jll library is will be required.
|
Do you have the skills to fix the issue in the libopencl_jll ? That would
be much appreciated.
Em ter., 23 de jan. de 2024 19:12, OGriebel ***@***.***>
escreveu:
… This is about issues #205
<#205> #206
<#206>.
#196 <#196> introduced breaking
changes for MacOS.
!!! Consider this commit as a dirty workaround to get macos back running
now.
With version 0.9.0 of OpenCL.jl, the following output is returned for
macos (x86).
julia> device, ctx, queue = cl.create_compute_context()
ERROR: CLError(code=-1001, CL_PLATFORM_NOT_FOUND_KHR)
Stacktrace:
[1] macro expansion
@ ~/.julia/packages/OpenCL/BTcrM/src/macros.jl:6 [inlined]
[2] platforms()
@ OpenCL.cl ~/.julia/packages/OpenCL/BTcrM/src/platform.jl:43
[3] create_some_context()
@ OpenCL.cl ~/.julia/packages/OpenCL/BTcrM/src/context.jl:277
[4] create_compute_context()
@ OpenCL.cl ~/.julia/packages/OpenCL/BTcrM/src/util.jl:2
[5] top-level scope
@ REPL[2]:1
This commit reverts the changes from #196
<#196> for macos, only. Other
OS versions should not be affected. However, this requires to be validated
by others. Following output is returned for my macos (x86).
julia> device, ctx, queue = cl.create_compute_context()
(OpenCL.Device(Intel(R) UHD Graphics 630 on Apple @0x0000000001024500), ***@***.*** on Intel(R) UHD Graphics 630), ***@***.***))
------------------------------
Fixing this bug properly, requires changes to the OpenCL_jll library.
Roughly, the following steps are required:
...
# These are the platforms we will build for by default, unless further# platforms are passed in on the command line
platforms = supported_platforms(; exclude=(Sys.iswindows || Sys.isapple))
platforms_macos = [ Platform("x86_64", "macos"), Platform("aarch64", "macos") ] # Support M-Series Processors as well?
# The products that we will ensure are always built
products = [
LibraryProduct("libOpenCL", :libopencl)
]
products_macos = [
FrameworkProduct("libOpenCL", :libopencl)
]
# Dependencies that must be installed before this package can be built
dependencies = [
BuildDependency(PackageSpec(; name="OpenCL_Headers_jll", version=v"2022.09.23"))
]
dependencies_macos = [
# At this point it is not clear to me, how to change OpenCL_Headers_jll.
]
# Build the tarballs, and possibly a `build.jl` as well.if any(should_build_platform.(triplet.(platforms)))
build_tarballs(ARGS, name, version, sources, script, platforms, products, dependencies; julia_compat="1.6", preferred_gcc_version = v"6.1.0")endif any(should_build_platform.(triplet.(platforms_macos)))
build_tarballs(ARGS, name, version, sources, script, platforms_macos, products_macos, dependencies_macos; julia_compat="1.6", preferred_gcc_version = v"6.1.0")end
------------------------------
You can view, comment on, or merge this pull request online at:
#209
Commit Summary
- 144af56
<144af56>
Add macos support
- d8f55b7
<d8f55b7>
Add Libdl
File Changes
(2 files <https://github.com/JuliaGPU/OpenCL.jl/pull/209/files>)
- *M* Project.toml
<https://github.com/JuliaGPU/OpenCL.jl/pull/209/files#diff-72ed386c2a0cd1d23c0968297e70023ed98c22490d146dd89fc91f48369bad4d>
(1)
- *M* src/api.jl
<https://github.com/JuliaGPU/OpenCL.jl/pull/209/files#diff-5223be791c850df6b50e8950a30d18af4e58e429c96f51a52a9a743165a4f91d>
(11)
Patch Links:
- https://github.com/JuliaGPU/OpenCL.jl/pull/209.patch
- https://github.com/JuliaGPU/OpenCL.jl/pull/209.diff
—
Reply to this email directly, view it on GitHub
<#209>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZQW3NUL62DMTYIBQM4MTTYQAYUDAVCNFSM6AAAAABCHX5KQ6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGA4TOMBXGU2TEMQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
Short answer, unfortunately not. Long answer: I never tried to fix a *_jll library with BinaryBuilder on Yggdrasil. If you could provide me with a reference on how to work with these, I might have a try. |
|
Search for OpenCL in my Github profile and you will find a repo with some
instructions on how I built the jll. There is also the video tutorial on
binarybuilder.jl which is super helpful.
Em ter., 23 de jan. de 2024 19:51, OGriebel ***@***.***>
escreveu:
… Short answer, unfortunately not.
Long answer:
My understanding of FrameworkProduct() and the respective dependencies is
somewhat limited. In case this works similar to LibraryProduct(), the
changes should be minor.
I never tried to fix a *_jll library with BinaryBuilder on Yggdrasil. If
you could provide me with a reference on how to work with these, I might
have a try.
—
Reply to this email directly, view it on GitHub
<#209 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZQW3J5R52SPS5JTRPSF2DYQA5GDAVCNFSM6AAAAABCHX5KQ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBXGA2TANZQGE>
.
You are receiving this because you commented.Message ID: <JuliaGPU/OpenCL.
***@***.***>
|
|
Thanks, I will have a look into it. It might take a bit though, as the library is running for the moment. Other parts of my project will be done first but added to the list. Consider this hotfix closed for now. As soon as I am successful, I will create pull requests to all affected repositories and revert the changes of this commit. |
|
This PR isn't applicable after the recent refactor (and wasn't a viable solution anyway), so I propose closing it and continuing the discussion in #205. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is about issues #205 #206.
#196 introduced breaking changes for MacOS.
!!! Consider this commit as a dirty workaround to get macos back running now.
With version 0.9.0 of OpenCL.jl, the following output is returned for macos (x86).
This commit reverts the changes from #196 for macos, only. Other OS versions should not be affected. However, this requires to be validated by others. Following output is returned for my macos (x86).
Fixing this bug properly, requires changes to the OpenCL_jll library. Roughly, the following steps are required: