Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the platform OpenCL library on Apple. #221

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Sep 10, 2024

Fixes #205

I'm not inclined to merge this, though. Apple has deprecated OpenCL, only supporting v1.2, which is ancient. I'll leave this up in case somebody really needs this, and wants to finish this. That would either involve making everything compatible with OpenCL v1.2, or introducing an opt-in preference to use the system OpenCL platform for backwards compatibility.

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 53.33%. Comparing base (9ccf867) to head (d766d80).

Files with missing lines Patch % Lines
src/util.jl 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #221       +/-   ##
===========================================
- Coverage   70.45%   53.33%   -17.13%     
===========================================
  Files           3        3               
  Lines         132      135        +3     
===========================================
- Hits           93       72       -21     
- Misses         39       63       +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maleadt maleadt mentioned this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v0.9.0 breaks MacOS
1 participant