Make copies from host to device blocking #243
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the following simple example fails:
It's very surprising to me that we haven't encountered this issue with our other back-ends. I assume that CUDA.jl's handling of unpinned memory (which it first copies synchronously into a pinned staging buffer) masks a lot of issues here.
Still, we'll probably have to make this change in other back-ends as well, because the memory could just as well have been fried before the copy finishes.