Skip to content

Fix index calculation in 2D gather/scatter#23

Merged
maleadt merged 1 commit intoJuliaGPU:mainfrom
AntonOresten:gather-2d
Jan 12, 2026
Merged

Fix index calculation in 2D gather/scatter#23
maleadt merged 1 commit intoJuliaGPU:mainfrom
AntonOresten:gather-2d

Conversation

@AntonOresten
Copy link
Contributor

After #12, the * in gather and scatter ended up doing matmul instead of broadcasted multiplication:

linear_idx = idx0_i32 * stride0 + idx1_i32 * stride1

Copy link
Member

@maleadt maleadt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops; thanks!

@maleadt maleadt merged commit 5fc9f71 into JuliaGPU:main Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants