Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like #5, but similar to how the DXILWriter in LLVM proper currently works. I had high hopes for this approach, because it doesn't mutate the module, doesn't need to inject additional intrinsics or metadata. However after hacking on it for a day or two it seems like:
An example of the fragility:
The pointer analysis pass deduces that
%box
isi64*
, but%box
falls back toi8*
, resulting in a crash when deserializing theselect
with two differently-typed pointer inputs