Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Turing and Soss dependencies #167

Merged
merged 2 commits into from
Jun 4, 2021
Merged

Update Turing and Soss dependencies #167

merged 2 commits into from
Jun 4, 2021

Conversation

devmotion
Copy link
Member

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #167 (9300ff9) into master (957320a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #167   +/-   ##
=======================================
  Coverage   99.23%   99.23%           
=======================================
  Files           9        9           
  Lines         260      260           
=======================================
  Hits          258      258           
  Misses          2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 957320a...9300ff9. Read the comment docs.

Copy link
Member

@willtebbutt willtebbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like Distibutions@0.25 still isn't being used, but Turing, Soss, and SampleChainsDynamicsHMC have been updated, so I'm going to approve.

@theogf
Copy link
Member

theogf commented Jun 4, 2021

Since we just want to maintain compatibility with Turing and Soss do we really need to check nightly ?

@devmotion
Copy link
Member Author

Only the standard CI uses nightly, Turing and Soss are only tested with the stable Julia version and only on linux.

@devmotion
Copy link
Member Author

Looks like Distibutions@0.25 still isn't being used, but Turing, Soss, and SampleChainsDynamicsHMC have been updated, so I'm going to approve.

Yes, I noticed this. I thought also we should drop old versions (Turing < 0.16 is not compatible with ChainRulesCore 0.10), so maybe let's stick with Distributions 0.24 for now and use the CompatHelper PR as a reminder that it should be updated eventually?

@theogf
Copy link
Member

theogf commented Jun 4, 2021

Only the standard CI uses nightly, Turing and Soss are only tested with the stable Julia version and only on linux.

Oh right I read the CI wrong! 😅

@devmotion
Copy link
Member Author

Good to go?

@devmotion devmotion merged commit 70ac23e into master Jun 4, 2021
@devmotion devmotion deleted the dw/ppl branch June 4, 2021 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants