-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Turing and Soss dependencies #167
Conversation
Codecov Report
@@ Coverage Diff @@
## master #167 +/- ##
=======================================
Coverage 99.23% 99.23%
=======================================
Files 9 9
Lines 260 260
=======================================
Hits 258 258
Misses 2 2 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like Distibutions@0.25 still isn't being used, but Turing, Soss, and SampleChainsDynamicsHMC have been updated, so I'm going to approve.
Since we just want to maintain compatibility with Turing and Soss do we really need to check |
Only the standard CI uses nightly, Turing and Soss are only tested with the stable Julia version and only on linux. |
Yes, I noticed this. I thought also we should drop old versions (Turing < 0.16 is not compatible with ChainRulesCore 0.10), so maybe let's stick with Distributions 0.24 for now and use the CompatHelper PR as a reminder that it should be updated eventually? |
Oh right I read the CI wrong! 😅 |
Good to go? |
No description provided.