-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CompatHelper: bump compat for "Distributions" to "0.25" for package ppl #168
CompatHelper: bump compat for "Distributions" to "0.25" for package ppl #168
Conversation
70fa7e4
to
237c137
Compare
Codecov Report
@@ Coverage Diff @@
## master #168 +/- ##
=======================================
Coverage 98.02% 98.02%
=======================================
Files 10 10
Lines 355 355
=======================================
Hits 348 348
Misses 7 7 Continue to review full report at Codecov.
|
…15-459-1871410325
Some package holds it back, I guess one should check manually what it is. |
…15-459-1871410325
That's just the standard test environment without Turing and Soss. It then later activates the ppl project environment and there Distributions 0.24 is used: https://github.com/JuliaGaussianProcesses/AbstractGPs.jl/pull/168/checks?check_run_id=2804074722#step:6:518 |
…15-459-1871410325
…15-459-1871410325
Still stuck on Distributions 0.24. Could we have an explicit check for whether the latest version in each compat entry is actually the one installed ? It's so tedious having to manually hunt for it each time... |
This feature is already included in the Github action on new Julia versions (julia-actions/julia-runtest#20). However, here we use a separate project environment for the PPL tests (and not test/Project.toml) and hence this automatic feature does not work. |
The automatic feature also won't work for the docs/Project.toml and the examples/*/Project.toml... |
It relies on a feature of Pkg in newer Julia versions (JuliaLang/Pkg.jl#2439), so it might be possible to call |
…15-459-1871410325
Closed in favor of #227 |
This pull request changes the compat entry for the
Distributions
package from0.24
to0.24, 0.25
for package ppl.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.