Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for "Distributions" to "0.25" for package ppl #168

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jun 5, 2021

This pull request changes the compat entry for the Distributions package from 0.24 to 0.24, 0.25 for package ppl.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

@theogf theogf force-pushed the compathelper/new_version/2021-06-05-01-25-15-459-1871410325 branch from 70fa7e4 to 237c137 Compare June 5, 2021 01:25
@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2021

Codecov Report

Merging #168 (63a3cb0) into master (b8eba64) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #168   +/-   ##
=======================================
  Coverage   98.02%   98.02%           
=======================================
  Files          10       10           
  Lines         355      355           
=======================================
  Hits          348      348           
  Misses          7        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8eba64...63a3cb0. Read the comment docs.

@devmotion
Copy link
Member

Some package holds it back, I guess one should check manually what it is.

@theogf
Copy link
Member

theogf commented Jun 11, 2021

Really? I checked and thought it said 25
image

@devmotion
Copy link
Member

That's just the standard test environment without Turing and Soss. It then later activates the ppl project environment and there Distributions 0.24 is used: https://github.com/JuliaGaussianProcesses/AbstractGPs.jl/pull/168/checks?check_run_id=2804074722#step:6:518

@st--
Copy link
Member

st-- commented Aug 11, 2021

Still stuck on Distributions 0.24. Could we have an explicit check for whether the latest version in each compat entry is actually the one installed ? It's so tedious having to manually hunt for it each time...

@devmotion
Copy link
Member

This feature is already included in the Github action on new Julia versions (julia-actions/julia-runtest#20). However, here we use a separate project environment for the PPL tests (and not test/Project.toml) and hence this automatic feature does not work.

@st--
Copy link
Member

st-- commented Aug 11, 2021

The automatic feature also won't work for the docs/Project.toml and the examples/*/Project.toml...

@devmotion
Copy link
Member

It relies on a feature of Pkg in newer Julia versions (JuliaLang/Pkg.jl#2439), so it might be possible to call Pkg.check_force_latest_compatible_version directly.

@st-- st-- requested a review from theogf August 12, 2021 14:03
@theogf
Copy link
Member

theogf commented Sep 30, 2021

Closed in favor of #227

@theogf theogf closed this Sep 30, 2021
@theogf theogf deleted the compathelper/new_version/2021-06-05-01-25-15-459-1871410325 branch September 30, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants