Refactor LatentGPs #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 202 204 +2
=========================================
+ Hits 202 204 +2
Continue to review full report at Codecov.
|
willtebbutt
reviewed
Jul 17, 2020
willtebbutt
reviewed
Jul 17, 2020
No worries! I missed BTW, Can we rename LatentGPs once this is merged? |
|
Just needs a patch bump. |
Fine by me. |
willtebbutt
approved these changes
Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements changes discussed in JuliaGaussianProcesses/GPLikelihoods.jl#4. Particularly, this comment by @willtebbutt.
LatentGPtoLatentFiniteGPLatentGPwhich comprises of theGP, the likelihood and observation noise and not the inputsx.