Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for CairoMakie to 0.11 for package 3-parametric-heteroscedastic, (keep existing compat) #387

Merged

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the CairoMakie package from 0.7, 0.8, 0.9, 0.10 to 0.7, 0.8, 0.9, 0.10, 0.11 for package 3-parametric-heteroscedastic.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

…tric-heteroscedastic, (keep existing compat)
@github-actions github-actions bot force-pushed the compathelper/new_version/2023-11-22-01-12-54-785-00569285464 branch from 2cdc8e0 to d389528 Compare November 22, 2023 01:13
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.95%. Comparing base (5b5687e) to head (10955b9).
Report is 1 commits behind head on master.

❗ Current head 10955b9 differs from pull request most recent head 560c308. Consider uploading reports for the commit 560c308 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #387   +/-   ##
=======================================
  Coverage   96.95%   96.95%           
=======================================
  Files          12       12           
  Lines         394      394           
=======================================
  Hits          382      382           
  Misses         12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willtebbutt
Copy link
Member

@devmotion looks like this is restricted to 0.10 due to AbstractGPsMakie being restricted to Makie 0.19. Do you know if it's going to be a straightforward upgrade for AbstractGPsMakie? (Also, should we just being using an extension now, rather than a separate package?)

@simsurace simsurace merged commit d48692c into master Mar 10, 2024
7 of 9 checks passed
@simsurace simsurace deleted the compathelper/new_version/2023-11-22-01-12-54-785-00569285464 branch March 10, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants