Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Julia formatter #5

Merged
merged 5 commits into from
Mar 6, 2024
Merged

Add Julia formatter #5

merged 5 commits into from
Mar 6, 2024

Conversation

simsurace
Copy link
Member

No description provided.

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (master@95244c8). Click here to learn what that means.

❗ Current head a844da2 differs from pull request most recent head 2c327fd. Consider uploading reports for the commit 2c327fd to get more accurate results

Files Patch % Lines
src/EasyGPs.jl 82.35% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master       #5   +/-   ##
=========================================
  Coverage          ?   92.47%           
=========================================
  Files             ?        1           
  Lines             ?       93           
  Branches          ?        0           
=========================================
  Hits              ?       86           
  Misses            ?        7           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simsurace
Copy link
Member Author

simsurace commented Mar 6, 2024

@theogf it doesn't seem to work though, when I run it locally it changes a few lines so I would expect it to comment on this PR. Or does it only do this on new changes?

@theogf
Copy link
Member

theogf commented Mar 6, 2024

Ah maybe you need to commit the changes? Did you copy the KernelFunctions.jl job?

examples/0-mauna-loa/script.jl Outdated Show resolved Hide resolved
examples/0-mauna-loa/script.jl Outdated Show resolved Hide resolved
src/EasyGPs.jl Outdated Show resolved Hide resolved
src/EasyGPs.jl Outdated Show resolved Hide resolved
src/EasyGPs.jl Outdated Show resolved Hide resolved
test/integration_tests.jl Outdated Show resolved Hide resolved
test/integration_tests.jl Outdated Show resolved Hide resolved
test/unit_tests.jl Outdated Show resolved Hide resolved
test/unit_tests.jl Outdated Show resolved Hide resolved
test/unit_tests.jl Outdated Show resolved Hide resolved
@theogf
Copy link
Member

theogf commented Mar 6, 2024

Looks like it works now 🎉

@simsurace simsurace merged commit fb8359a into master Mar 6, 2024
3 checks passed
@simsurace simsurace deleted the julia-formatter branch March 6, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants