Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update compat helper #97

Merged
merged 2 commits into from
Feb 23, 2023
Merged

update compat helper #97

merged 2 commits into from
Feb 23, 2023

Conversation

willtebbutt
Copy link
Member

Upgrades compat helper to the latest version of the GHA

Upgrades compat helper to the latest version of the GHA
Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, we should definitely use version 3. I started a CompatHelper run with the changes in this PR to see if everything works correctly: https://github.com/JuliaGaussianProcesses/GPLikelihoods.jl/actions/runs/4252591667/jobs/7396376500

Feel free to merge if it passes and my comment below is addressed 🙂

.github/workflows/CompatHelper.yml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Base: 96.37% // Head: 96.37% // No change to project coverage 👍

Coverage data is based on head (f40bdee) compared to base (4b33f7a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #97   +/-   ##
=======================================
  Coverage   96.37%   96.37%           
=======================================
  Files          10       10           
  Lines         138      138           
=======================================
  Hits          133      133           
  Misses          5        5           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
@willtebbutt
Copy link
Member Author

Thanks for the review @devmotion . Will merge when CI passes

@willtebbutt willtebbutt merged commit 011018f into master Feb 23, 2023
@willtebbutt willtebbutt deleted the wct/compat-helper-upgrade branch February 23, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants