Remove public marker from exported symbols
#19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise loading the package on nightly gives errors like: `LoadError: cannot declare AdaptivePredicates.orient2 public; it is already declared exported`.
|
Ah. I didn't think it would matter.. that's annoying. Can you bump the version? |
|
Sure, bumped in dc52b79. |
|
Thanks for this. I'll try and make a similar fix in DelaunayTriangulation.jl soon since I think I do the same mistake there. |
|
Once JuliaGeometry/DelaunayTriangulation.jl#168 is in hopefully that's all that needs to be fixed. Feel free to let me know if there are any other issues. |
|
Thanks, can confirm those two fix nightly ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise loading the package on nightly gives errors like:
LoadError: cannot declare AdaptivePredicates.orient2 public; it is already declared exported. Exported symbols are implicitly marked as public so it shouldn't be necessary anyway.Would it be possible to make a new release when this is merged? Otherwise it's not possible to install any dependent packages on nightly like Makie/DelaunayTriangulation.