`?connect` example has typos, also, it does not work

[JeffreySarnoff]

help?> connect
search: connect continue countlines count_ones

  connect(points::AbstractVector{<: AbstractPoint}, P::Type{<: Polytype{N}}, skip::Int = N)

  Creates a view that connects a number of points to a Polytope P. Between each polytope, skip elements are skipped
  untill the next starts. Example: ```julia x = connect(Point[(1, 2), (3, 4), (5, 6), (7, 8)], Line, 2) x ==
  [Line(Point(1, 2), Point(3, 4)), Line(Point(5, 6), Point(7, 8))]

julia> x = connect(Point[(1, 2), (3, 4), (5, 6), (7, 8)], Line, 2)
ERROR: MethodError: no method matching Polytope(::Type{Line{Dim, T} where T where Dim}, ::Type{Point})
Closest candidates are:
  Polytope(::Type{var"#s10"} where var"#s10"<:(GeometryBasics.Ngon{Dim, T, N, P} where P where T where Dim), ::Type{var"#s9"} where var"#s9"<:AbstractPoint{NDim, T}) where {N, NDim, T} at C:\Users\jas\.julia\packages\GeometryBasics\csguK\src\basic_types.jl:89
Stacktrace:
 [1] connect(points::Vector{Point}, P::Type{Line{Dim, T} where T where Dim}, skip::Int64)
   @ GeometryBasics ~\.julia\packages\GeometryBasics\csguK\src\viewtypes.jl:77
 [2] top-level scope
   @ REPL[13]:1

[juliohm]

I have a branch `cleanup` where I fixed several problems in the code. Can you give it a try? There is an open PR with additional changes as well.

…

On Sun, Oct 11, 2020, 18:06 Jeffrey Sarnoff ***@***.***> wrote: help?> connect search: connect continue countlines count_ones connect(points::AbstractVector{<: AbstractPoint}, P::Type{<: Polytype{N}}, skip::Int = N) Creates a view that connects a number of points to a Polytope P. Between each polytope, skip elements are skipped untill the next starts. Example: ```julia x = connect(Point[(1, 2), (3, 4), (5, 6), (7, 8)], Line, 2) x == [Line(Point(1, 2), Point(3, 4)), Line(Point(5, 6), Point(7, 8))] julia> x = connect(Point[(1, 2), (3, 4), (5, 6), (7, 8)], Line, 2) ERROR: MethodError: no method matching Polytope(::Type{Line{Dim, T} where T where Dim}, ::Type{Point}) Closest candidates are: Polytope(::Type{var"#s10"} where var"#s10"<:(GeometryBasics.Ngon{Dim, T, N, P} where P where T where Dim), ::Type{var"#s9"} where var"#s9"<:AbstractPoint{NDim, T}) where {N, NDim, T} at C:\Users\jas\.julia\packages\GeometryBasics\csguK\src\basic_types.jl:89 Stacktrace: [1] connect(points::Vector{Point}, P::Type{Line{Dim, T} where T where Dim}, skip::Int64) @ GeometryBasics ~\.julia\packages\GeometryBasics\csguK\src\viewtypes.jl:77 [2] top-level scope @ REPL[13]:1 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#102>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZQW3IA5GZTISCBE7ZKKJ3SKIM7DANCNFSM4SMAWXRA> .

[JeffreySarnoff]

I tried using GeometryBasics#cleanup. The help text is unchanged, and the example errors in the same way. It is as though the changes were not sticking. I do not see any current revision in this branch.

[juliohm]

Did you try the PR branch ? I'm going over a major refactoring of the codebase to avoid exactly these types of issues you're encountering. There is a long way to go. It would be nice to know if things are still failing somewhere there.

…

On Sun, Oct 11, 2020, 20:10 Jeffrey Sarnoff ***@***.***> wrote: I tried using GeometryBasics#cleanup. The help text is unchanged, and the example errors in the same way. It is as though the changes were not sticking. I do not see any current revision in this branch. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#102 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZQW3LZ6JJHR7JXW2CTLEDSKI3MXANCNFSM4SMAWXRA> .

[JeffreySarnoff]

On the #points branch, the error is different:

search: connect continue countlines count_ones

  connect(points::AbstractVector{<: AbstractPoint}, P::Type{<: Polytype{N}}, skip::Int = N)

  Creates a view that connects a number of points to a Polytope P. Between each polytope, skip elements are skipped
  untill the next starts. Example: ```julia x = connect(Point[(1, 2), (3, 4), (5, 6), (7, 8)], Line, 2) x ==
  [Line(Point(1, 2), Point(3, 4)), Line(Point(5, 6), Point(7, 8))]

julia>  x = connect(Point[(1, 2), (3, 4), (5, 6), (7, 8)], Line, 2)
ERROR: MethodError: Cannot `convert` an object of type
  Tuple{Int64, Int64} to an object of type
  Point
Closest candidates are:
  convert(::Type{T}, ::T) where T at essentials.jl:205
  Point(::Tuple{Vararg{T, N}}) where {N, T} at C:\Users\jas\.julia\packages\GeometryBasics\2aU8e\src\points.jl:25
  Point(::T...) where {N, T} at C:\Users\jas\.julia\packages\GeometryBasics\2aU8e\src\points.jl:26
Stacktrace:
 [1] setindex!(A::Vector{Point}, x::Tuple{Int64, Int64}, i1::Int64)
   @ Base .\array.jl:847
 [2] getindex(::Type{Point}, ::Tuple{Int64, Int64}, ::Tuple{Int64, Int64}, ::Tuple{Int64, Int64}, ::Tuple{Int64, Int64})
   @ Base .\array.jl:408
 [3] top-level scope
   @ REPL[5]:1

[JeffreySarnoff]

give me what I should type after pkg> add

[juliohm]

Try it with Point2[(1,2), ...] in the #points branch.

[JeffreySarnoff]

yup:

julia> x = connect(Point2[(1, 2), (3, 4), (5, 6), (7, 8)], Line, 2)
2-element reinterpret(Line{2, Float64}, ::TupleView{Tuple{Point2, Point2}, 2, 2, Vector{Point2}}):
 Line(Point2([1.0, 2.0]) => Point2([3.0, 4.0]))
 Line(Point2([5.0, 6.0]) => Point2([7.0, 8.0]))

[JeffreySarnoff]

and it will work with Point if mapped or broadcasted:

julia> y = connect(map(xy->Point(xy...),[(1, 2), (3, 4), (5, 6), (7, 8)]), Line, 2)
2-element reinterpret(Line{2, Int64}, ::TupleView{Tuple{Point{2, Int64}, Point{2, Int64}}, 2, 2, Vector{Point{2, Int64}}}):
 Line(Point{2, Int64}([1, 2]) => Point{2, Int64}([3, 4]))
 Line(Point{2, Int64}([5, 6]) => Point{2, Int64}([7, 8]))

julia> y = connect(Point.([(1, 2), (3, 4), (5, 6), (7, 8)]), Line, 2)
2-element reinterpret(Line{2, Int64}, ::TupleView{Tuple{Point{2, Int64}, Point{2, Int64}}, 2, 2, Vector{Point{2, Int64}}}):
 Line(Point{2, Int64}([1, 2]) => Point{2, Int64}([3, 4]))
 Line(Point{2, Int64}([5, 6]) => Point{2, Int64}([7, 8]))

[juliohm]

I could add a convert method for the generic Point so that it would figure out the type from the tuples in that PR. Do you really need integer coordinates in your use case?

[juliohm]

Currently in that PR, we have Point2 and Point3 for double precision and Point2f and Point2f for single precision. The generic Point constructor inherits the eltype of the tuple, but it doesn't work when you use it with arrays as in Point[(1,2), ...] because I didn't add a convert method for it (yet). I will try to add it tomorrow.

Closing this issue. 👍

[JeffreySarnoff]

Thank you for the prompt help. I'll take a look at the way Points are established tonight .. it would be a boon for there to be no more restriction on the numerical type used for coordinates than the familiar flexibility we have with them generally.