Add Extents.extent method for Rect2 #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been pirated in Tyler and should rather live in GeometryBasics.
|
Thanks! Good to fix that type piracy. (Also Extends doesnt actually extend GeoInterface, its not really Geo specific) |
rafaqz
approved these changes
Jun 13, 2023
|
Bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been pirated in Tyler and should rather live in GeometryBasics.
This would enable us to use this method in PyramidScheme without having to depend on Tyler for example.
I put the definition into the GeoInterface file because for me the Extents is an extension of the GeoInterface.
I am not sure, whether it would make sense to also provide the extent functionality also for higher dimensional rectangles or other geometry types, but the Rect2 is needed for the subsetting in Tyler.
@rafaqz