Skip to content

Fix Polygon constructor type signature #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 24, 2025
Merged

Fix Polygon constructor type signature #237

merged 2 commits into from
Jan 24, 2025

Conversation

favba
Copy link
Contributor

@favba favba commented Jan 17, 2025

Fixes #236

@ffreyer
Copy link
Collaborator

ffreyer commented Jan 18, 2025

Thanks. Could you also add the example from the issue as a test?

@favba
Copy link
Contributor Author

favba commented Jan 18, 2025

Test added!

@favba
Copy link
Contributor Author

favba commented Jan 23, 2025

Friendly bump! This should be ready to go.

@SimonDanisch SimonDanisch merged commit 9974a79 into JuliaGeometry:master Jan 24, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffreyer ffreyer ffreyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Polygon(::AbstractVector) method not working on v0.5 for non base Vector types
3 participants
@favba @ffreyer @SimonDanisch