Skip to content
This repository has been archived by the owner on Oct 12, 2019. It is now read-only.

Feature/tweak testing #38

Merged
merged 4 commits into from
Mar 23, 2015

Conversation

KristofferC
Copy link
Contributor

  • Enables testing with coverage=true to output the .cov.jl files that Coverage uses to send to Coveralls.
  • Moves the Lint to the test/REQUIRE file since it isn't strictly needed to run the package.

@coveralls
Copy link

Coverage Status

Coverage increased (+44.36%) to 44.36% when pulling 0da38b4 on KristofferC:feature/tweak_testing into fb88e73 on JuliaGeometry:master.

@KristofferC
Copy link
Contributor Author

Lint seem to fail to initialize in v0.4 causing the test for v0.4 to fail.

Warning: error initializing module Lint:
Base.AssertionError(msg="typeof(ex.args[3]) == Symbol")
ERROR: LoadError: LoadError: LoadError: LoadError: UndefVarError: RTLD_GLOBAL not defined

Don't really know why...

@sjkelly
Copy link
Member

sjkelly commented Mar 23, 2015

This was probably caused by the LibC and LibDL move (JuliaLang/julia#10328)

One alternative I have used is wrap using Lint; lingpkg(); in if "--lint" in ARGS so that lint is only run with runtests.jl --lint. I kind of find the lint output annoying after a while and less informative.

Otherwise these changes look good to me! I think you can self-merge, so feel free to do so when you are ready.

@KristofferC
Copy link
Contributor Author

Yeah, maybe there isn't a big point in automatic linting at test unless failing to lint cleanly is considered a test failure.

Should I rebase the branch to squash the commits to a single one?

@sjkelly
Copy link
Member

sjkelly commented Mar 23, 2015

rebase and squash might be nice but not nessecary. I was realizing how much I polluted the git history on this repo by working directly on master a couple days ago...

@sjkelly
Copy link
Member

sjkelly commented Mar 23, 2015

I am alos seeing the same failure on JuliaGeometry/Meshes.jl#39. I think the best thing to do here is put lint behind a CLI option and not bother running it on travis.

sjkelly added a commit that referenced this pull request Mar 23, 2015
@sjkelly sjkelly merged commit d555383 into JuliaGeometry:master Mar 23, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants