Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix principal_value method #180

Merged
merged 3 commits into from
Nov 1, 2021

Conversation

hyrodium
Copy link
Collaborator

@hyrodium hyrodium commented Nov 1, 2021

This PR fixes #179.

julia> principal_value(RodriguesParam(1,2,3))
3×3 RodriguesParam{Int64} with indices SOneTo(3)×SOneTo(3)(1, 2, 3):
 -0.733333  -0.133333  0.666667
  0.666667  -0.333333  0.666667
  0.133333   0.933333  0.333333

julia> principal_value(Angle2d(5.0))
2×2 Angle2d{Float64} with indices SOneTo(2)×SOneTo(2)(-1.28319):
  0.283662  0.958924
 -0.958924  0.283662

@hyrodium hyrodium requested a review from andyferris November 1, 2021 10:07
@hyrodium hyrodium changed the title Bugfix/principal value Fix principal_value method Nov 1, 2021
@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

Merging #180 (83244fe) into master (20a730f) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #180      +/-   ##
==========================================
+ Coverage   86.33%   86.41%   +0.07%     
==========================================
  Files          14       14              
  Lines        1325     1325              
==========================================
+ Hits         1144     1145       +1     
+ Misses        181      180       -1     
Impacted Files Coverage Δ
src/principal_value.jl 100.00% <100.00%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20a730f...83244fe. Read the comment docs.

@hyrodium hyrodium merged commit 9fd3ea1 into JuliaGeometry:master Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing principal_value methods
2 participants