Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 2d rotation_angle #92

Merged
merged 3 commits into from
Feb 6, 2019
Merged

add 2d rotation_angle #92

merged 3 commits into from
Feb 6, 2019

Conversation

jw3126
Copy link
Contributor

@jw3126 jw3126 commented Feb 5, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Feb 5, 2019

Codecov Report

Merging #92 into master will decrease coverage by 15.02%.
The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #92       +/-   ##
===========================================
- Coverage   86.99%   71.97%   -15.03%     
===========================================
  Files           9        8        -1     
  Lines         746      735       -11     
===========================================
- Hits          649      529      -120     
- Misses         97      206      +109
Impacted Files Coverage Δ
src/core_types.jl 74.22% <71.42%> (-12.51%) ⬇️
src/util.jl 40% <0%> (-50%) ⬇️
src/derivatives.jl 40.9% <0%> (-45.46%) ⬇️
src/quaternion_types.jl 52.99% <0%> (-42.74%) ⬇️
src/angleaxis_types.jl 71.95% <0%> (-20.74%) ⬇️
src/principal_value.jl 83.33% <0%> (-12.5%) ⬇️
src/euler_types.jl 83.52% <0%> (-0.97%) ⬇️
src/Rotations.jl

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5b1635...c1efbe4. Read the comment docs.

Copy link
Contributor

@tkoolen tkoolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

src/core_types.jl Outdated Show resolved Hide resolved
Copy link
Contributor

@tkoolen tkoolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/core_types.jl Outdated Show resolved Hide resolved
@tkoolen
Copy link
Contributor

tkoolen commented Feb 6, 2019

Great, thanks!

@tkoolen tkoolen merged commit 27a632a into JuliaGeometry:master Feb 6, 2019
@tkoolen
Copy link
Contributor

tkoolen commented Feb 6, 2019

JuliaLang/METADATA.jl#21218

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants