Permit gc on fps nodes #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm waiting to see if this one passes tests. |
|
Unless you made changes somewhere, this won't pass tests without further bugfixes. Something is broken with both |
|
Yeah I was trying to fix that and failing to reproduce similar failures in the REPL. Will take a look again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests don't pass, but hopefully you can fix that? This version seems to allow cleanup of fps-created nodes. As with #76, it's not really obvious to me why this works when the previous one didn't. But I at least find this version easier to read anyway, so hopefully this is a step forward.