conditionally use SpecialFunctions
through weak deps or Requires
#186
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #184.
Fix #182.
Fix last part of JuliaPlots/UnicodePlots.jl#291.
This is a proposal to make all the
SpecialFunctions
related functions (which are clearly piracy) optional using weak dependencies onjulia
>= 1.9 andRequires
on older releases.This would be (slightly) breaking so I guess we should bump
ColorVectorSpace
to0.10.0
if this PR is merged, since you'd have to use:to recover all the functionalities on current master.
Note that
lfact
is renamed tologfactorial
sincelfact
was deprecated inSpecialFunctions
.I followed the guidelines in https://pkgdocs.julialang.org/dev/creating-packages/#Conditional-loading-of-code-in-packages-(Extensions) and https://docs.julialang.org/en/v1.10-dev/manual/code-loading/#man-extensions.
This PR was written for
ColorSchemes
, andpkg> test ColorSchemes
passes locally sinceColorSchemes
does not depend on theSpecialFunctions
functionalities defined inColorVectorSpace
.Latency improvements:
PR
master
Ping @timholy or @kimikage or @johnnychen94 for review (primary contributors to this repo).