-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore non-DICOM files in a directory #83
Conversation
added `try` and `catch` statements which should get around the fact that not all directories are pure DICOM files
fixed `isdicom`
Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
Thanks for catching and fixing this @Dale-Black ! I think the tests are currently failing because the EDIT: I opened a PR on your branch. |
Create an invalid file during tests to check isdicom()
Sorry this took a while, I was busy with finals. I just merged your PR @notZaki so hopefully that fixes everything. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
==========================================
+ Coverage 92.57% 92.85% +0.28%
==========================================
Files 2 2
Lines 377 392 +15
==========================================
+ Hits 349 364 +15
Misses 28 28
Continue to review full report at Codecov.
|
LGTM. |
This PR allows
dcmdir_parse
to work in a directory with non-DICOM-related files. Currently, mac users will run into problems due to.DS_Store
andIcon
metadata files. This PR modifiesisdicom
to account for that.A test and a non-DICOM image were also added to make sure
isdicom
is working properly