-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate KomaMRI into simpler subpackages #92
Comments
We need to think what goes where: KomaMRI (UI, All the rest); KomaMRIBase (simulation); KomaMRIPlots (Plots)
|
(needed) CUDA = "3" <---Base (needed) FileIO = "1" <---Base, IO (needed) AssetRegistry = "0.1" <---UI |
For the moment, it was decided to separate the package in: ├── KomaMRI.jl: includes the KomaUI and Reconstruction (dependencies: Blink, Mux, MRIReco, KomaMRICore, KomaMRIPlots, etc).
│ ├── KomaMRICore.jl: least amount of dependencies, just simulation, and IO: Pulseq, ISMRMRD, etc.
│ └── KomaMRIPlots.jl: just the Plots, mainly to remove PlotlyJS as a dependency as it could be a heavy package.
@beorostica Please use these names. All the KomaUI.jl stuff is part of KomaMRI.jl, not KomaMRIPlots. KomaMRIPlots should include the functions defined in DisplayFunctions.jl. For the time being, I would focus on KomaMRICore. |
This issue should not be closed as separating the IO part is necessary @beorostica. Also we will remove │ ├── KomaMRICore.jl: least amount of dependencies, just simulation There are some questions that are important:
We need to reevaluate the dependancies given the changes that are being done to the internal interpolation. |
This needs to be done to remove a lot of the dependencies of the UI like Blink, PlotlyJS, etc.
The idea of doing this is to reduce the number of dependencies to the minimum if someone just wants to simulate data.
To replace MRIReco, the KomaMRIBase package should use instead:
MRIBase
-> RawAcquisitionData
-> AcquisitionData
MRIFiles
-> ISMRMRD
Then, the KomaMRI package can have other dependencies.
Not sure if the plots for our datatypes should be included in KomaMRIBase. Maybe also have KomaMRIPlots?
In summary:
├── KomaMRI.jl (depends on Base and UI)
│ ├── KomaMRIBase.jl (least dependencies)
│ └── KomaMRIPlots.jl (separated to include plots only if needed)
We will need to think about the best way to do this.
Subpackages:
The text was updated successfully, but these errors were encountered: