-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Motion Phantom #183
Closed
Closed
Motion Phantom #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is meant to implement Koma's HDF5 Phantom file format (.phantom) in a way that supports different motion models (Related with #73). For this we need to implement:
SimpleMotion<:MotionModel
struct that will replace the currently usedux
,uy
, andux
fields to have more extensible motion models.ArbitraryMotion<:MotionModel
struct designed to generate arbitrary non-rigid motions. This will enable different structures (spin groups) to have separated motions, in contrast toSimpleMotion
that applies the same displacement field to all the spins.read_phantom
that will read a .phantom file and generate an indexed or explicitPhantom
struct.write_phantom
that will write a .phantom file from aPhantom
struct.