KomaMRIIO subpackage #229
KomaMRIIO subpackage #229
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #229 +/- ##
==========================================
- Coverage 91.60% 90.72% -0.89%
==========================================
Files 31 31
Lines 2252 2274 +22
==========================================
Hits 2063 2063
- Misses 189 211 +22
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| export read_seq | ||
| #ISMRMRD | ||
| export signal_to_raw_data | ||
| export recursive_merge |
There was a problem hiding this comment.
why are you exporting this? You are doing KomaMRICore.recursive_merge. This is not needed.
There was a problem hiding this comment.
I didn't intend to make any changes to KomaMRICore. This was a mistake in the commit.
| MRIBase = "f7771a9a-6e57-4e71-863b-6e4b6a2f17df" | ||
| MRIFiles = "5a6f062f-bf45-497d-b654-ad17aae2a530" |
There was a problem hiding this comment.
We utilize EncodingCounters() from MRIBase and Limits() from MRIFiles.
|
|
||
| # Phantom | ||
| export read_phantom_jemris, read_phantom_MRiLab | ||
|
|
There was a problem hiding this comment.
This is missing a KomaMRIIO.__VERSION__ variable (This is why Pkg is being imported).
There was a problem hiding this comment.
You are right. It is going to be added.
|
There is another pull request, #231, that will add KomaMRIIO. |
No description provided.