Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KomaMRIIO subpackage #231

Merged
merged 41 commits into from
Dec 1, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
3ca7139
Update phantom section with pelvis example in docs
beorostica Nov 22, 2023
1bd5ee7
Add simple contributing guidelines
beorostica Nov 22, 2023
f7d0fcc
Create simple KomaMRIIO subpackage
beorostica Nov 27, 2023
d69698e
Update ci.yml and minor dependency changes for KomaMRIIO
beorostica Nov 28, 2023
210c517
Remove MRI dependencies from KomaMRIIO
beorostica Nov 28, 2023
bb696e9
Update ci.yml to include codecov for KomaMRIIO
beorostica Nov 28, 2023
3eaace2
Merge branch 'master' into komaio
beorostica Nov 28, 2023
93dc116
Reexport ISMRMRDFile from KomaMRIIO
beorostica Nov 28, 2023
2150390
Use functions from KomaMRIIO and reduce number of dependencies
beorostica Nov 29, 2023
80ec68c
Use descriptive names for folders in KomaMRIIO
beorostica Nov 29, 2023
f65c8fc
Add KomaMRIIO version in UI
beorostica Nov 29, 2023
a4dbfdf
Update CONTRIBUTING.md
beorostica Nov 29, 2023
66e65f3
Merge branch 'master' into komaio
beorostica Nov 29, 2023
1e81082
Update ci.yml to consider develop environment of KomaMRIIO
beorostica Nov 29, 2023
5f8cb28
Consider KomaMRIIO in docs generation
beorostica Nov 29, 2023
072f361
Update contributing guidelines
beorostica Nov 29, 2023
721fef5
Include a Contributing section in README.md
beorostica Nov 29, 2023
094243f
Remove KomaMRIIO from KomaMRIPlots
beorostica Nov 29, 2023
9ca5957
Remove the unnecessary KomaMRIIO prefix from function calls
beorostica Nov 29, 2023
5ad188e
Update README.md with information about KomaMRIIO
beorostica Nov 29, 2023
36fd490
Update README.md
beorostica Nov 29, 2023
f425357
Update README.md
beorostica Nov 29, 2023
a7145d6
Use KomaMRIIO for testing KomaMRICore
beorostica Nov 30, 2023
f9e5e84
Utilize multiple-dispatching for simulation output
beorostica Nov 30, 2023
d9b7b2a
Change InteractiveUtils compat
beorostica Nov 30, 2023
1bef1df
Change name of simulation output structs
beorostica Nov 30, 2023
97640b1
Add consistent names for simulation output structs
beorostica Nov 30, 2023
8ff77bb
Move signal_to_raw_data() to KomaMRICore
beorostica Nov 30, 2023
dfda824
Remove simulation output functions
beorostica Nov 30, 2023
091441d
Remove InteractiveUtils package
beorostica Nov 30, 2023
2597f59
Remove show() tests
beorostica Nov 30, 2023
c85b5df
Simple tests for show() function
beorostica Nov 30, 2023
f42277c
Create a function to update encoding parameters for RawAcquisitionData
beorostica Dec 1, 2023
2115656
Fix XML saving
beorostica Dec 1, 2023
f624ab4
Rewrite insertNode function
beorostica Dec 1, 2023
2194121
Remove import for EncodingEncounters
beorostica Dec 1, 2023
7f48a03
Explicit types in ISMRMRD
cncastillo Dec 1, 2023
0a24ee5
Remove unnecessary KomaMRICore from test environment of KomaMRIIO
beorostica Dec 1, 2023
21e472e
Merge branch 'komaio' of github.com:cncastillo/KomaMRI.jl into komaio
beorostica Dec 1, 2023
7348532
Removes off-resonance from default UI phantom
cncastillo Dec 1, 2023
435f8f8
Merge branch 'master' into komaio
cncastillo Dec 1, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions KomaMRIIO/src/KomaMRIIO.jl
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ module KomaMRIIO

using KomaMRICore
using Scanf, FileIO, HDF5, MAT, JLD2 # IO related
using MRIBase # At least for EncodingCounters()
using MRIFiles # At least for Limits()
cncastillo marked this conversation as resolved.
Show resolved Hide resolved

include("io/Pulseq.jl")
include("io/JEMRIS.jl")
Expand Down
20 changes: 10 additions & 10 deletions KomaMRIIO/src/io/ISMRMRD.jl
Original file line number Diff line number Diff line change
Expand Up @@ -80,15 +80,15 @@ function signal_to_raw_data(
"encodedSize" => [Nx, Ny, 1], #encodedSpace>matrixSize
"reconSize" => [Nx+Nx%2, Ny+Ny%2, 1], #reconSpace>matrixSize
#encodingLimits>
"enc_lim_kspace_encoding_step_1" => Limit(0, Nx-1, ceil(Int, Nx / 2)), #min, max, center, e.g. phase encoding line number
"enc_lim_kspace_encoding_step_2" => Limit(0, 0, 0), #min, max, center, e.g. partition encoding number
"enc_lim_average" => Limit(0, 0, 0), #min, max, center, e.g. signal average number
"enc_lim_slice" => Limit(0, 0, 0), #min, max, center, e.g. imaging slice number
"enc_lim_contrast" => Limit(0, 0, 0), #min, max, center, e.g. echo number in multi-echo
"enc_lim_phase" => Limit(0, 0, 0), #min, max, center, e.g. cardiac phase number
"enc_lim_repetition" => Limit(0, 0, 0), #min, max, center, e.g. dynamic number for dynamic scanning
"enc_lim_set" => Limit(0, 0, 0), #min, max, center, e.g. flow encoding set
"enc_lim_segment" => Limit(0, 0, 0), #min, max, center, #segment: e.g. segment number for segmented acquisition
"enc_lim_kspace_encoding_step_1" => KomaMRICore.Limit(0, Nx-1, ceil(Int, Nx / 2)), #min, max, center, e.g. phase encoding line number
"enc_lim_kspace_encoding_step_2" => KomaMRICore.Limit(0, 0, 0), #min, max, center, e.g. partition encoding number
"enc_lim_average" => KomaMRICore.Limit(0, 0, 0), #min, max, center, e.g. signal average number
"enc_lim_slice" => KomaMRICore.Limit(0, 0, 0), #min, max, center, e.g. imaging slice number
"enc_lim_contrast" => KomaMRICore.Limit(0, 0, 0), #min, max, center, e.g. echo number in multi-echo
"enc_lim_phase" => KomaMRICore.Limit(0, 0, 0), #min, max, center, e.g. cardiac phase number
"enc_lim_repetition" => KomaMRICore.Limit(0, 0, 0), #min, max, center, e.g. dynamic number for dynamic scanning
"enc_lim_set" => KomaMRICore.Limit(0, 0, 0), #min, max, center, e.g. flow encoding set
"enc_lim_segment" => KomaMRICore.Limit(0, 0, 0), #min, max, center, #segment: e.g. segment number for segmented acquisition
cncastillo marked this conversation as resolved.
Show resolved Hide resolved
#sequenceParameters
# "TR" => 0,
# "TE" => 0,
Expand Down Expand Up @@ -133,7 +133,7 @@ function signal_to_raw_data(
(0.0f0, 1.0f0, 0.0f0), #phase_dir: Directional cosines of the phase
(0.0f0, 0.0f0, 1.0f0), #slice_dir: Directional cosines of the slice direction
(0.0f0, 0.0f0, 0.0f0), #patient_table_position: Patient table off-center
EncodingCounters( #idx: Encoding loop counters
KomaMRICore.EncodingCounters( #idx: Encoding loop counters
cncastillo marked this conversation as resolved.
Show resolved Hide resolved
scan_counter, #kspace_encode_step_1: e.g. phase encoding line number
0, #kspace_encode_step_2: e.g. partition encoding number
0, #average: e.g. signal average number
Expand Down